search

zackyang000 / node-odata

A library for easily create OData REST API, abide by OData protocol.
http://zackyang000.github.io/node-odata/en/
MIT License
365 stars 65 forks source link

Makefile breaks on Windows #64

Open andrerpena opened 8 years ago

andrerpena commented 8 years ago

Hi. First, thanks for this project. I have interest in it and I would eventually contribute.

My problem is that you're using MAKE which doesn't work on Windows (at least not on my installation). I have never used a Makefile before but from where I'm standing, you're just using it to perform operations Node.js people would do in a Node.js way :smile: And this is preventing me from compiling it.

Can I remove the Makefile file and create corresponding package.json scripts? I mean, would you accept a PR?

Thank you.

zackyang000 commented 8 years ago

You are absolute correct. I choose Makefile to build this project because Makefile is easier maintain than npm script. Makefile has a little trouble running on windows, you have to install some tools for use MAKE command.

You can write it in package.json if you want, I will merge and appreciate it.