zacs / ha-dualmodegeneric

Generic thermostat capable of heating and cooling
68 stars 26 forks source link

[Feature request] Separate cold_ and hot_tolerance settings for each mode #10

Closed ab0tj closed 2 years ago

ab0tj commented 4 years ago

I currently use two separate generic_thermostat instances to control a furnace and an evaporative cooler. In order to prevent short cycling on the cooler, I use a fairly high hot_tolerance setting on the thermostat for the cooler. I suspect this would not be a great thing during the winter when the furnace is running. It would be wonderful to have separate settings based on if it is currently heating or cooling.

I'll also look at the code to see if I could just do this and submit a pull request, but Python is not my strong suit. Thanks for all your hard work on this component!

KairuByte commented 3 years ago

Are you certain this isn't already possible? The readme claims that all existing options of the generic thermostat integration should work/exist, and separate hot/cold tolerances is one such option.

zacs commented 3 years ago

When I put the plugin together I copied the mainline generic_thermostat and made updates, so yes that should work.

On Thu, Nov 12, 2020 at 7:59 PM KairuByte notifications@github.com wrote:

Are you certain this isn't already possible? The readme claims that all existing options of the generic thermostat integration should work/exist, and separate hot/cold tolerances is one such option.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zacs/ha-dualmodegeneric/issues/10#issuecomment-726492962, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGYOI5EYOMJZ275QGOPBLSPSVJLANCNFSM4PFDJWIA .