search

zacs / ha-dualmodegeneric

Generic thermostat capable of heating and cooling
68 stars 26 forks source link

[Feature Request] Support one away_temp value for both heater and cooler #17

Closed brizoo closed 3 years ago

brizoo commented 3 years ago

Hi zacs, and thanks a lot for this integration that I use in my ha environment and is really helpfull to me :)

I have AC climate units that does both heating and cooling and I'm using this integration to avoid having two climates entities for the same physical device

I'm asking for a feature request here since I think it's missing one crucial thing: having one away_temp value for the heater and one for the cooler! In winter, away_temp is around 18, which makes sense. But if I turn on the cooler during summer around 25° and then when leaving home, putting the "away mode", the temperature of the thermostat will be set to 18° and it will be cool, but maybe to much !! :) So the only possibility right now is to change away_temp manually and reboot the server every season.

The idea is to have "away_temp_cooler" and "away_temp_heater" variables that will be used respectively with cooler and heater. it would makes sense to me.

What do you think about this?

Thanks,

brizoo commented 3 years ago

Hi zacs, Just modified the code myself and created a pull request: #18

brizoo commented 3 years ago

Hi @zacs Do you need anything else from me? Is that possible that we merge please? I'm still forced to avoid the updates and would like to be able to keep on the master branch :) Thanks,