search

zacs / ha-dualmodegeneric

Generic thermostat capable of heating and cooling
68 stars 26 forks source link

[Feature Request] Support one away_temp value for both heater and cooler #18

Closed brizoo closed 3 years ago

brizoo commented 3 years ago

Hi guys, following support request I did earlier. I've decided to do it myself and looked into the code, first time in Python! I hope you will find the idea good and merge my changes :) Thanks,

brizoo commented 3 years ago

Hi Zacs, thanks a lot for your positive welcome to this addition to your code :) I've done changes as requested to keep interoperability with older versions, which makes sense indeed!

Please feel free to verify, really excited for the merge ! Thanks

zacs commented 3 years ago

Nice, thank you! Working on fixing a bug I introduced by supporting heat_cool (auto) mode at the moment. After that I will make sure this PR doesn't conflict and get it merged. Appreciate the quick turnaround.

brizoo commented 3 years ago

Hello @zacs I think this is a quick change to merge and would be good to finally stop having my own version running. May you please review and merge ?

Thanks,

brizoo commented 3 years ago

I have merged my changes with the last version of the master branch (including fan and dry modes). Please merge ASAP so I won't have to maintain it anymore ;) Thanks !

zacs commented 3 years ago

Thank you for updates, merging when I get back to desktop.