Closed bbbates closed 4 years ago
Thanks for submitting this! I will bump my HA install and test it today, then merge in.
@bbbates Just read through code and all looks kosher, just one question: does your addition require the reverse_cycle
property? Ideally it would be optional to specify, which would need a default set in PLATFORM_SCHEMA
section.
Really like this addition since it's so appropriate for dual mode.
I will also look into formally submitting to HACS once this is ready and merged, hopefully more than a dozen or so people can find it useful that way.
@zacs reverse_cycle
is optional in the schema, and I think because it's a boolean it will default to false, right?
Either way, I've explictly set it now.
I've also been testing this in v108 for the last week now, and all looks good so far 👍
Thanks for changing -- probably should've checked myself before asking ;).
This worked on v0.99 of HA.
However, I've just upgraded my installation to 108, and finding that the thermostat doesn't switch on until I change the temperature state.This may have actually been due to the dodgy way I was switching on my air-con - need to investigate further 🤔There does seem to be some recent fixes to the generic thermostat integration (https://github.com/home-assistant/core/commits/dev/homeassistant/components/generic_thermostat/climate.py) so will incorporate those into another PR down the track.
Thanks for the initial work on this integration! Has been super useful so far. We should look to get it into HACS at some point.