search

zacs / ha-dualmodegeneric

Generic thermostat capable of heating and cooling
68 stars 26 forks source link

Merge with core? #20

Closed mbrevda closed 3 years ago

mbrevda commented 3 years ago

Was wondering if it would make sense to merge these changes with the generic_theormostat that in core instead of requing HACS?

zacs commented 3 years ago

I certainly agree -- although I suppose it would be more of a template_thermostat since that is a bit more in line (for naming) with other template devices. But having seen the insane bar for entry into core, I don't think there's much chance that I'm able to spend the time to get that done.

mbrevda commented 3 years ago

Oh, didn't realize it was that challenging. If you work up the the courage, drop a link to the PR here - would love to follow along!

On Fri, May 21, 2021, 7:38 PM Zac @.***> wrote:

I certainly agree -- although I suppose it would be more of a template_thermostat since that is a bit more in line (for naming) with other template devices. But having seen the insane bar for entry into core, I don't think there's much chance that I'm able to spend the time to get that done.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zacs/ha-dualmodegeneric/issues/20#issuecomment-846091522, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACHRDGOYWM2V5DDHQER5KDTO2D7TANCNFSM45JBISIA .

zacs commented 3 years ago

Appreciate the support! Unfortunately since HA is used by so many people and in so many different environments, they [rightly] have a pretty high quality bar for getting into the core. Will close this issue for now, thanks!