search

zacs / ha-dualmodegeneric

Generic thermostat capable of heating and cooling
68 stars 26 forks source link

"Precision" feature not working #33

Closed dave0111 closed 2 years ago

dave0111 commented 2 years ago

"Precision" feature, natively integrated in generic_thermostat component is not recognized by the custom thermosat: even though it is set to 1.0, i still get steps of 0.5°

sebastianeferrer commented 2 years ago

Found the issue we should add target_temperatura_set() declaration as generic thermostat does https://github.com/zacs/ha-dualmodegeneric/blob/44b241939627d7eedd7e47de07eac65e2c98056d/custom_components/dualmode_generic/climate.py#L487

    @property
    def target_temperature_step(self):
        """Return the supported step of target temperature."""
        # Since this integration does not yet have a step size parameter
        # we have to re-use the precision as the step size for now.
        return self.precision
sebastianeferrer commented 2 years ago

https://github.com/zacs/ha-dualmodegeneric/pull/34

You can get the fix from PR34

sebastianeferrer commented 2 years ago

https://github.com/zacs/ha-dualmodegeneric/pull/34 was merged, you can close this issue now.

david-kalbermatten commented 2 years ago

34 was merged, you can close this issue now.

not quite, I only reviewed and approved the changes. @zacs has to merge it. I don't have maintainer rights :D