zacs / ha-nfl

NFL game scores custom component for Home Assistant
42 stars 32 forks source link

Wrong text #24

Closed JGNi closed 1 year ago

JGNi commented 1 year ago

The text in HA hasn't been changed from the weather forked edition.

gonzotek commented 1 year ago

In Home Assistant, or the HACS information popup for the integration? Searching the repo for 'weather', I only find two files, one is the nws_alerts_custom_package.yaml in the packages folder, the other is the info.md file at the repo root. This looks like it is what is displayed in the HACS information, and probably is what needs to be fixed. It looks like the same basic kind of description and installation info as what is contained in readme.md (only info.md still refers to weather, while readme.md is up to date with NFL stuff), so a simple fix would be to just mirror the content from readme to info.

The package yaml could probably just be dropped, as looking at the contents, I'm not sure there's anything worth salvaging/porting to over to NFL.

JGNi commented 1 year ago

HACS - when you click the integration

Alerts from the US National Weather Service (nws_alerts)
Possible Breaking Change
Modified the format of the list of event_id in the attributes

Description
An updated version of the nws_alerts custom integration for Home Assistant originally found at github.com/eracknaphobia/nws_custom_component

This integration retrieves updated weather alerts every minute from the US NWS API.

The integration presents the number of currently active alerts as the state of the sensor and lists many alert details as a list in the attributes of the sensor.

The sensor that is created is used in my "NWS Alerts Custom" package - https://github.com/finity69x2/NWS-Alerts-Custom-Package
firstof9 commented 1 year ago

Just copy the readme.md to info.md or change the hacs.json to use the readme instead of info.md