search

zacs / ha-nfl

NFL game scores custom component for Home Assistant
43 stars 32 forks source link

London game fix (Location missing State info) and hacs default repo prep work #28

Closed gonzotek closed 2 years ago

gonzotek commented 2 years ago

wrap values["location"] in try/except to catch games with no State info (e.g. the 10/2/2022 MIN @ NO London game)

codecov-commenter commented 2 years ago

Codecov Report

Base: 63.77% // Head: 63.77% // No change to project coverage :thumbsup:

Coverage data is based on head (509badc) compared to base (bf46ecd). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #28 +/- ## ======================================= Coverage 63.77% 63.77% ======================================= Files 2 2 Lines 196 196 ======================================= Hits 125 125 Misses 71 71 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

gonzotek commented 2 years ago

Yeah...so I'm not sure what to do with the hassfst fail...it's indicating a translation problem, but afaik, my two-liner fix didn't touch anything translation-related.

gonzotek commented 2 years ago

Resolved the hassfest fail: since 'NFL' is a brand, the integration title doesn't need to be translated. Then went ahead and added the hacs github action and resolved its fails. This should put the integration on track (or nearly so) for placing into the HACS default repositories.