zadam / trilium-sender

Simple android application for sending images and notes to Trilium
GNU General Public License v3.0
80 stars 31 forks source link

Clean up the project! #10

Closed elementc closed 4 years ago

elementc commented 4 years ago

Wanted to have a warning-free build of the project on the latest Android Studio version.

elementc commented 4 years ago

Happy to help! @zadam want to run a couple other changes I've been wanting to make by you: 1) refactor into just the one launcher entry, with the connection settings being hidden away in a menu 2) support receiving share intents of other types- particularly links, so I can share websites, reddit links, tweets, etc, directly from the native android UI 3) maybe a setting to put a label on the entries this adds to Trilium so that incoming shares are searchable? 4) tag a release so this can be added to fdroid!

Any of these particularly distasteful to you? Let me know so that I don't waste your time on incoming PRs you aren't thrilled about.

zadam commented 4 years ago

All of these sound good to me!

elementc commented 4 years ago

@zadam would you mind adding the hacktoberfest-accepted label to this PR? Don't mean to be a bother, but I am trying to keep my Hacktoberfest streak up this year :) https://hacktoberfest.digitalocean.com/details show how it works. no need to unilaterally opt any of your projects in to hacktoberfest with the hacktoberfest repo topic, if you're concerned about annoying low-quality drivebys (and if you are but still want to participate, happy to volunteer an hour a day pre-screening them for you).

zadam commented 4 years ago

Done.