search

zadam / trilium-sender

Simple android application for sending images and notes to Trilium
GNU General Public License v3.0
80 stars 31 forks source link

Users can now specify a note label to apply to their sent notes. #12

Closed elementc closed 3 years ago

elementc commented 3 years ago

I ran into some issues while developing this, outlined in https://github.com/zadam/trilium/issues/1397 We should not merge this change until that bug is fixed.

elementc commented 3 years ago

Outlining the various UI changes:

I changed the "Connection Settings" button to be named "Settings" in support of the new features we added to it.

I split the settings UI into two sections, one for Login Settings and one for Note Settings. Under Note Settings, I added a text entry field for a note label. If the login settings are present, when loading this activity, a message will be shown below the login button so that users know they have these settings already saved. I modified the activity to pull its' label from a string resource, and made the label more generic.

I modified the login activity to restore the URL and the label settings contents when the activity loads.

<img src="https://user-images.githubusercontent.com/4315099/98495144-5e6e7980-21f3-11eb-8001-54c2b98efb0d.png" width=300/> I modified the edit note activity to show a label strip underneath the note title, when a label is saved in the settings.

elementc commented 3 years ago

Okay, thanks for the help over on https://github.com/zadam/trilium/issues/1397! This is ready to review now, @zadam