search

zadam / trilium-web-clipper

Save web clippings to Trilium Notes.
GNU General Public License v3.0
256 stars 52 forks source link

Only getting a small portion of page #17

Open JetsonDavis opened 4 years ago

JetsonDavis commented 4 years ago

I have xpi extension installed on Firefox and clicking 'Save Whole Page'. I get a pop-up dialog at the bottom of the screen. When I click the link and go to Trillium, I only get a small portion of text from the page. Am I doing something wrong?

For example, say I do a google search for 'nothing'. All I get is the top of the page.

image
zadam commented 4 years ago

Hi, I can reproduce this behavior on the google search results page.

Trilium is not saving the page "as is" (which would be difficult anyway), but it's trying to extract the meaningful content using the https://github.com/mozilla/readability library. That involves some guesswork though and while it's mostly correct, it can be wrong at times. Google search result isn't really a typical usecase for this but yeah, I guess omitting the actual results is probably wrong thing to do.

So this would have to be fixed in the readability library first ...

JetsonDavis commented 4 years ago

I just used Google results as an easy example but not having much luck with other pages either. nbd

Btw, any thoughts of a mobile version of Trillium?

Thx!

On Aug 11, 2020, at 11:55 AM, zadam notifications@github.com wrote:

Hi, I can reproduce this behavior on the google search results page.

Trilium is not saving the page "as is" (which would be difficult anyway), but it's trying to extract the meaningful content using the https://github.com/mozilla/readability https://github.com/mozilla/readability library. That involves some guesswork though and while it's mostly correct, it can be wrong at times. Google search result isn't really a typical usecase for this but yeah, I guess omitting the actual results is probably wrong thing to do.

So this would have to be fixed in the readability library first ...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zadam/trilium-web-clipper/issues/17#issuecomment-672195388, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGV3PXQDYAF7N6MYW5ACVLSAGHZTANCNFSM4P2VHIBQ.

zadam commented 4 years ago

Can you give some non-google example?

There's mobile frontend: https://github.com/zadam/trilium/wiki/Mobile-frontend

But native Android/iOS apps are probably not going to happen.

JetsonDavis commented 4 years ago

For instance, https://www.electronjs.org/apps/trilium-notes https://www.electronjs.org/apps/trilium-notes

Results in this:

Anyway, discovered Apple Notes works for my very light use case. Thanks Adam!

On Aug 11, 2020, at 3:04 PM, zadam notifications@github.com wrote:

Can you give some non-google example?

There's mobile frontend: https://github.com/zadam/trilium/wiki/Mobile-frontend https://github.com/zadam/trilium/wiki/Mobile-frontend But native Android/iOS apps are probably not going to happen.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zadam/trilium-web-clipper/issues/17#issuecomment-672304089, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGV3PRI7EGU2NMK2ERAH7TSAG56TANCNFSM4P2VHIBQ.