search

zadam / trilium-web-clipper

Save web clippings to Trilium Notes.
GNU General Public License v3.0
256 stars 53 forks source link

Capture location.hash into pageUrl attribute #61

Closed contributor closed 6 months ago

contributor commented 6 months ago

Currently, when you clip a selection from a page with a named section, the pageUrl attribute is captured without named section. Consequently, when you click “This note was originally taken from” link in the captured note, you are navigated to the top of the page, and not to the named section.

Example of a page with named sections:

https://herbertograca.com/2017/11/16/explicit-architecture-01-ddd-hexagonal-onion-clean-cqrs-how-i-put-it-all-together/#ports

Currently, clipping loses #ports part. This PR preserves #ports in the resulting pageUrl attribute.

zadam commented 6 months ago

Hi, I merged your PR, however please note that Trilium is in maintenance mode and the WebClipper might not see another release.

contributor commented 6 months ago

Yeah, it is sad. I hope there will be a web clipper release. At least from trilium next project.

For anyone who (like me) who uses Firefox and not Chrome, the extension is still relevant. I suppose that changes to Chrome extension manifests won't affect extension for Firefox.

And it is always possible to load extension in Firefox from source code manually, though it is not as convenient as signed package.