zadam / trilium

Build your personal knowledge base with Trilium Notes
GNU Affero General Public License v3.0
27.33k stars 1.92k forks source link

(Feature request) Add non-intrusive internet connection lost message #2366

Open Myzel394 opened 2 years ago

Myzel394 commented 2 years ago

Preflight Checklist

Describe feature

When you have no internet connection and try to open notes, you will always get these notification boxes. They are not really understandable by people who are not versatile with computers.

I would suggest creating a non-intrusive banner at the top that shows that the internet is missing (see screenshot example from protonmail.com)

image

Additional Information

No response

zadam commented 2 years ago

Hi, do you mean on server version? Since on desktop for opening notes you don't need internet connection. Internet is needed for sync only and with that lack of internet is silent (only sync status icon changes). It would be useful if you could provide a screenshot and more context. Thx.

Myzel394 commented 2 years ago

Yes I mean the the server version.

Here's what we could implement:

image

Myzel394 commented 2 years ago

@zadam what do you think?

zadam commented 2 years ago

I guess why not?

(although it seems a bit ... superfluous? I mean with webapps running in a browser there is a general understanding that they don't work offline)

Myzel394 commented 2 years ago

although it seems a bit ... superfluous? I mean with webapps running in a browser there is a general understanding that they don't work offline

Yes of course :D, but at least we don't get spammed with this box notification which is exactly in the center of the page and is kind of annoying once you realize you don't have any internet

zadam commented 2 years ago

Ok, I'm not against this if you're willing to submit a PR.

Myzel394 commented 2 years ago

Btw, does anyone know if there's a name for this kind of message?