zadam / trilium

Build your personal knowledge base with Trilium Notes
GNU Affero General Public License v3.0
27.2k stars 1.9k forks source link

(Bug report) Keystrokes lost when tabbing out of title quickly #2566

Closed agentydragon closed 2 years ago

agentydragon commented 2 years ago

Trilium Version

0.48.9

What operating system are you using?

Ubuntu

What is your setup?

Local + server sync

Operating System Version

Pop!_OS 21.10

Description

Create a new page, start typing the title, then quickly Tab out of it and start writing the body.

If you do this too quickly, some of the last keystrokes in the title will be lost.

See video: https://www.youtube.com/watch?v=blJP_wUO2Do

zadam commented 2 years ago

Hi, thanks for reporting, unfortunately I can't reproduce it in 0.48.9 or later. But there has been already such bugs in the past.

I'm wondering if it's also reproducible without the Tab.

Is this the desktop or server?

Also, just to make sure, you don't have any scripts listening on note's changes, right?

agentydragon commented 2 years ago

This is the desktop client. I will later check if this also happens in the server when opened as a webpage.

I do have some custom JS that might be interfering - a custom component that should not be rendering in this note. I'll try turning it off and report back. Thanks :)

On Sat, 15 Jan 2022, 23:17 zadam, @.***> wrote:

Hi, thanks for reporting, unfortunately I can't reproduce it in 0.48.9 or later. But there has been already such bugs in the past.

I'm wondering if it's also reproducible without the Tab.

Is this the desktop or server?

Also, just to make sure, you don't have any scripts listening on note's changes, right?

— Reply to this email directly, view it on GitHub https://github.com/zadam/trilium/issues/2566#issuecomment-1013762862, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFORDAS6E4B5DG7B3QBEFDUWHW75ANCNFSM5MBO5ZHA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

agentydragon commented 2 years ago

This also happens when I access the server as a webpage in my browser. Turning off my custom #widgets did not fix this. I do have some scripts listening on attribute changes on some notes, but those notes I'm trying it on don't have that script attached - I create them anew with Ctrl+Alt+P with no scripts attached by relations.

The same bug occurs if I switch focus by clicking the new page's content after a bunch of keysmashing in the title, so it also happens without Tab.

zadam commented 2 years ago

Thanks, I was able to reproduce this and fix it. The missing part for me was that to reproduce it you need to switch to content and write (quickly after switching). Before I was doing just the Tab which alone does not suffice.

agentydragon commented 2 years ago

Thanks for solving this so quickly <3 Looking forward for a release with the fix