search

zadam / trilium

Build your personal knowledge base with Trilium Notes
GNU Affero General Public License v3.0
27.2k stars 1.9k forks source link

(Bug report) Webview not working in Browser #4648

Open Byteingpython opened 8 months ago

Byteingpython commented 8 months ago

Trilium Version

0.62.6

What operating system are you using?

Windows

What is your setup?

Server access only

Operating System Version

Windows 10

Description

Webviews are not working at all. When i acess children of webviews i get an error in the console. I read in the electron Docs that using the webview component is not recommended. Maybe it is also the issue that it is an electron component and i am using it in a browser

Error logs

Uncaught (in promise) TypeError: this.$noteDetailWebViewContent.removeAttribute is not a function cleanup web_view.js:57 refresh type_widget.js:24 noteSwitched note_context_aware_widget.js:83 noteSwitchedEvent note_context_aware_widget.js:78 callMethod component.js:104 handleEvent component.js:48 handleEventInChildren component.js:74 handleEvent component.js:50 handleEventInChildren component.js:74 handleEventInChildren scrolling_container.js:47 handleEvent component.js:50 handleEventInChildren component.js:74 handleEvent component.js:50 handleEventInChildren split_note_container.js:187 handleEvent component.js:50 handleEventInChildren component.js:74 handleEvent component.js:50 handleEventInChildren component.js:74 handleEvent component.js:50 handleEventInChildren component.js:74 handleEvent component.js:50 handleEventInChildren component.js:74 handleEvent component.js:50 handleEventInChildren component.js:74 handleEvent component.js:50 triggerEvent app_context.js:97 triggerEvent component.js:66 triggerEvent component.js:66 setNote note_context.js:72 activate note_tree.js:380 jQuery 8 click note_tree.js:348 jQuery 21 initFancyTree note_tree.js:284 doRender note_tree.js:232 promise callbackdoRender note_tree.js:232 render basic_widget.js:84 renderChildren container.js:11 doRender container.js:6 render basic_widget.js:84 renderChildren container.js:11 doRender container.js:6 render basic_widget.js:84 renderWidgets app_context.js:72 start app_context.js:37 async desktop.js:13 promise callback* desktop.js:11

desktop.js:30 desktop.js:30
zadam commented 8 months ago

Hello, WebView is Electron/Desktop feature only. Browsers don't support that. Perhaps this is not clearly communicated within the app.

Byteingpython commented 8 months ago

What about using iframes. Even the electron docs recommend that

zadam commented 8 months ago

I remember researching that back when I added the WebView support. The main problem is that websites can detect they're being loaded through iframe and most of them blocked such access.