zadam / trilium

Build your personal knowledge base with Trilium Notes
GNU Affero General Public License v3.0
27.14k stars 1.9k forks source link

Rich embeds #886

Open sharifkhalladi opened 4 years ago

sharifkhalladi commented 4 years ago

It would be useful to have the ability to include rich embeds without having to set up a code and render note and then using the "include note" functionality (I'm currently using this method to achieve rich media embeds, along with some minor CSS edits to hide the title of the included note).

I believe CKEditor has some native media embed capabilities but am unsure if we can simply enable these somehow.

I very much like how Outline approaches this, see an example here.

zadam commented 4 years ago

Yes, CKEditor has rich embed. I tried it a while ago and it did not work properly, but quite possibly it has been improved since. This would have to be enabled in the CKEditor build.

However I don't know if/how this would work with e.g. Airtable. I mean I don't know if all there is to integrate it is to enable this embedding and the rest will work automagically.

sambbaron commented 4 years ago

@zadam I am also interested in this.

https://ckeditor.com/docs/ckeditor5/latest/features/media-embed.html

chee commented 3 years ago

The media-embed library seems to be for embedding videos from websites like youtube. I'm primarily interested in embedding my own media, media that I have in another note. Similar to how you can see an image in the document it has been pasted into (it becomes an <img>), I'd like to be able to see included video notes become <video/> and audio become <audio/> without needing to create a render note.

Is that a new issue?

I can see that ckeditor provides a ckeditor5-image which is what you're using for this, but code for video and audio would be custom.

zadam commented 3 years ago

Hi, notes are normally added to another note through include note but this did not render a preview. I added it now so it looks like this:

image

chee commented 3 years ago

Hi, notes are normally added to another note through include note but this did not render a preview. I added it now so it looks like this:

image

oh!! that's so exciting! a few of my notes are about to look so good!! thank you so much :green_heart: