can not open in safari - Githubissues

zadam / trilium

Build your personal knowledge base with Trilium Notes

GNU Affero General Public License v3.0

27.2k stars 1.9k forks source link

can not open in safari #904

Closed iyjian closed 2 years ago

iyjian commented 4 years ago

For bug reports, please mention version of the application and include log files from following location:

/home/[user]/.local/share/trilium-data/log for Linux
C:\Users\[user]\AppData\Roaming\trilium-data\log for Windows Vista and up
/Users/[user]/Library/Application Support/trilium-data/log for Mac OS

after I run npm run start-server and registered as a new user, I found the follow error in safari console.

and I found the javascript file, It seems that safari do not have window.addEventEvent method. I am not sure is it a bug.

https://github.com/zadam/trilium/blob/master/src/public/javascripts/widgets/tab_row.js#L290

zadam commented 4 years ago

Hello, thanks for reporting this issue, this looks like a bug introduced after refactoring, I will fix that.

BTW, it looks like you are using master branch which is not yet completely stable. You might want to use stable branch instead.

iyjian commented 4 years ago

many thanks. I appreciate your opensource project! I like it!!!!!

iyjian commented 4 years ago

btw, I am using safari, and there is no scroll bar on the left panel, I am trying to figure it out.

iyjian commented 4 years ago

It seems that, it is a css bug of fancytree, I'll investigate it.

iyjian commented 4 years ago

could you let me know how do you generate the jquery.fancytree-all-deps.js? I use fancytree js as standalone but the scroll is ok in safari, I am going to do more investigate on the issue.

zadam commented 4 years ago

The missing scrollbar is probably not caused by the fancytree itself, but by the surrounding layout.

zadam commented 4 years ago

Also one note - Safari is generally not well supported (since it's available only on Mac, I can't use it to test) so you might encounter various issues. I will fix bugs as far as I can (which is not much with my inability to test), but generally I would recommend using Chrome or Firefox instead.

iyjian commented 4 years ago

it is absolutely ok.