SSH / Sample Pages Exetnsion - Githubissues

zadjii-msft / PowerToys

Windows system utilities to maximize productivity

MIT License

2 stars 2 forks source link

SSH / Sample Pages Exetnsion #50

Closed joadoumie closed 1 month ago

joadoumie commented 1 month ago

Summary of the Pull Request

PR Checklist

[ ] Closes: #xxx
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places
- [ ] JSON for signing for new binaries
- [ ] WXS for installer for new binaries and localization folder
- [ ] YML for CI pipeline for new test projects
- [ ] YML for signed pipeline
[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

joadoumie commented 1 month ago

@zadjii-msft: I can consistently reproduce a weird behavior of the form page where on first view attempt it's just an empty page and on the second view attempt it shows up as expected for the Sample Form Page Command.

joadoumie commented 1 month ago

Also noticing if I toggle back and forth really quickly on the sample markdown view (open command, escape to root, open command, escape to root, etc.) I can get into a state where I see 'System.String[]' instead of the markdown content.

joadoumie commented 1 month ago

Ok, talking to myself a little bit here, but writing so I don't forget:

I think maybe the two comments above are related. I can also get a somewhat random but consistent winui crash (I think) when I try to quickly reproduce either of the comments above.