search

zaeleus / noodles

Bioinformatics I/O libraries in Rust
MIT License
482 stars 52 forks source link

refget: Update to v2.0.0 specifications #186

Closed juliangehring closed 1 year ago

juliangehring commented 1 year ago

This PR addresses #185 and implements the minimal set of changes for updating the refget client to the current v2 refget specs.

The version number has been updated to v0.2.0 to reflect the breaking changes.

The dependencies of the crate have also been updated - however, this is fully optional.

Any comments are welcome.

juliangehring commented 1 year ago

Some basics test with the EBI refget server:

cargo run --example refget_download_sequence https://ebi.ac.uk/ena/cram/ 6681ac2f62509cfc220d78751b8dc524

cargo run --example refget_sequence_metadata https://ebi.ac.uk/ena/cram/ 6681ac2f62509cfc220d78751b8dc524

cargo run --example refget_service_info https://ebi.ac.uk/ena/cram/
zaeleus commented 1 year ago

Cool, thanks for keeping up with the spec!

The version number has been updated to v0.2.0 to reflect the breaking changes.

The dependencies of the crate have also been updated - however, this is fully optional.

I ended up reverting the manifest changes. noodles-refget isn't published (i.e., it currently has no version), and dependencies are synced across all crates.

ohofmann commented 1 year ago

Wow, that was fast. Thank you!