search

zafarkhaja / jsemver

Java implementation of the SemVer Specification
MIT License
429 stars 82 forks source link

Metod parameter is not being used. #20

Closed Kubuxu closed 1 year ago

Kubuxu commented 9 years ago

This method does not use input parameter: https://github.com/zafarkhaja/jsemver/blob/master/src/main/java/com/github/zafarkhaja/semver/VersionParser.java#L180

zafarkhaja commented 9 years ago

Hi @Kubuxu, thank you for the report.

I know it's not used, it's there just for the sake of Parser.parse(String input) signature compatibility to correctly implement the method. It felt right in the beginning to have a functional interface for the Parser which is also implemented by ExpressionParser. However, due to some previous design decisions, I failed to implement the VersionParser as a pure function, so it remains like that. At least for now.

Kubuxu commented 9 years ago

Oh. Would be it possible to annotate that in JavaDoc of this function in VersionParser. I was a little bit confused while reading that.

zafarkhaja commented 9 years ago

Sorry for the delay. Of course, I'll do so as soon as possible unless you want to submit a pull request.