search

zafarkhaja / jsemver

Java implementation of the SemVer Specification
MIT License
429 stars 82 forks source link

All version classes should be serializable #31

Closed rbellamy closed 1 year ago

rbellamy commented 7 years ago

Serializable version classes with unit test

This change is Reviewable

rbellamy commented 7 years ago

@zafarkhaja my PR is not the oldest on your list, so by no means am I trying to jump ahead in line - this is just a gentle ping to find out if you have any idea when you'll have a chance to merge these outstanding PR's?

rbellamy commented 7 years ago

@zafarkhaja - any word at all?

rbellamy commented 6 years ago

Gah, this is why GitHub Organizations are so useful. Once again, another project that is essentially dead because the original author couldn't be bothered...

zafarkhaja commented 1 year ago

Hello Richard, I hope you're doing well!

Your frustration was valid, and I'm sorry it took me this long to get back to you.

I appreciate you taking the time and effort to contribute, however I'd prefer serialization proxy pattern to using the default serialized form. I wasn't sure if you'd be still interested to resubmit, and, anyway, wanted to speed things up to clear the backlog as soon as possible, so I went ahead and implemented the feature myself (8c22fdf).

Have a nice day,