changes to the way versions are incremented to match how npm behaves.

zafarkhaja / jsemver

Java implementation of the SemVer Specification

MIT License

429 stars 82 forks source link

changes to the way versions are incremented to match how npm behaves. #50

Closed abersnaze closed 1 year ago

abersnaze commented 5 years ago

Users of our app were noticing that the way it increments versions with and without prerelease metadata was different from how npm version <inc type> behaves.

with the input 1.2.3-pre.1+build.1 the command npm version patch produces 1.2.3 but this library produces 1.2.4.

@srinivasankavitha

heisluft commented 5 years ago

Implemented this pr in my fork

zafarkhaja commented 1 year ago

Hello George, I hope you're doing well!

I'm sorry it took me this long to get back to you. And I appreciate you taking the time and effort to contribute.

I try to keep an open mind on matters not covered by the Specification, such as incrementing pre-release versions, but to be honest this behavior isn't intuitive to me. Before making such a change I'd like to discuss and look into it further, and preferably also see what other users' take on this is. Please open an issue If you're still interested.

Have a nice day,