replaced wget with requests to fix issue #4

zafercavdar / fasttext-langdetect

80x faster and 95% accurate language identification with Fasttext

MIT License

141 stars 21 forks source link

replaced wget with requests to fix issue #4 #5

Closed fogx closed 1 year ago

fogx commented 2 years ago

I've created a small PR to fix issue #4 by replacing wget with requests and adding that to the dependencies. I've also moved url into the if-case so it won't get initialized unnecessarily, and sorted the imports.

fogx commented 1 year ago

thanks for your feedback @zafercavdar. Since you wrote in #4 that the issue is fixed, i guess we can just close this PR? Otherwise i'll fix the topics you mentioned.

zafercavdar commented 1 year ago

I fixed most of my comments in this PR: https://github.com/zafercavdar/fasttext-langdetect/pull/8, merged/released.