zafross / NitroGiftGeneratorAndChecker

Nitro generator + checker to discord
65 stars 69 forks source link

Refactoring + improve perfomance #15

Closed homka122 closed 2 years ago

TKperson commented 3 years ago

Adding threads will never help it to performance better because the chance of getting a correct nitro code is close to zero. After adding threading module to it, the chance of getting a correct nitro code is still close to zero. Then, what is the difference between close to zero and close to zero?

Please check out this post (I did some calculation): https://github.com/lnxcz/nitro-generator/issues/8#issuecomment-764987352

homka122 commented 3 years ago

Adding threads will never help it to performance better because the chance of getting a correct nitro code is close to zero. After adding threading module to it, the chance of getting a correct nitro code is still close to zero. Then, what is the difference between close to zero and close to zero?

Please check out this post (I did some calculation): lnxcz/nitro-generator#8 (comment)

Yeah, I saw your post and I liked your calculations xD I just wanted to make some improves for self-study and to make my first fork in github Thank you for reply!