search

zagortenay333 / cronomix

All-in-one timer, stopwatch, pomodoro, alarm, todo and time tracker gnome-shell extension
MIT License
570 stars 74 forks source link

Translation not working #229

Closed lev741 closed 1 year ago

lev741 commented 1 year ago

Hi, I'm not sure if I'm making a mistake but even I used fresh instalation of Fedora 38 and putting everything on right place (~/.local/share/gnome-shell/extensions/cronomix@zagortenay333/locale/cs/LC_MESSAGES/cronomix.mo), the translation not working. I tried install by zip (from repo), by compilation, by hand, nothing working. No restart help... :(

Can you take a look at it if is my mistake or something different? Thnx a lot.

zagortenay333 commented 1 year ago

Yeah, It was a bug on my part. Should be fixed now.

lev741 commented 1 year ago

Well, only partial success. It works somewhere, somewhere not. Watch the attached video.

(Color glitches produced by my virtual. Don`t worry..)

Záznam obrazovky z 2023-06-08 15-08-10.webm

zagortenay333 commented 1 year ago

You're right, it's broken.

I'm currently waiting for someone to answer my question here: https://discourse.gnome.org/t/can-inittranslations-be-called-outside-the-init-function/15661

Btw, can you checkout if the popups are still being cut off? I pushed a fix for those. You commented on the issue here: https://github.com/zagortenay333/cronomix/issues/223

zagortenay333 commented 1 year ago

Ok, this should be fixed now for real.

lev741 commented 1 year ago

Sorry, nothing changes for translation. It looks the same.

Záznam obrazovky z 2023-06-09 12-35-11.webm

zagortenay333 commented 1 year ago

Are you sure you got the latest download? What does the extension.js file look like?

lev741 commented 1 year ago

Just now I tried with fresh source. Extension works in the same way. The basic screen of pomodoro works. Few textx too.

zagortenay333 commented 1 year ago

What does your extension.js file look like?

lev741 commented 1 year ago

Here is my in ~/.local/share/gnome-shell/extensions/cronomix@zagortenay333 extension.zip

zagortenay333 commented 1 year ago

That's not what the latest file looks like. I don't know how you go that. Download the zip from the README file. This one: https://github.com/zagortenay333/cronomix/blob/master/data/cronomix%40zagortenay333.zip

lev741 commented 1 year ago

At first. Translations is working for now. Great. Thank you! For me it is a little bit confusing, because sources from your github are the same except the comments on beginning of gnome.d.ts but the compiled result is completely different.

zagortenay333 commented 1 year ago

To get the same zip as the one on github you have to use the pack script, not build. The pack script ensures that the final js files retain blank lines.