zaguiini / formik-wizard

A multi-step form component powered by formik and react-albus
MIT License
86 stars 26 forks source link

Render props is deprecated #11

Closed KROSF closed 4 years ago

KROSF commented 4 years ago

https://jaredpalmer.com/formik/docs/migrating-v2#deprecation-warnings

zaguiini commented 4 years ago

Mind filling a PR?

michelts commented 4 years ago

Should we stick to the Formik's approach and replace our render by a child callback function?

zaguiini commented 4 years ago

I guess so since we'll need the props

michelts commented 4 years ago

I mean, we certainly should replace our implementation and use the child callback function instead of the render prop, when using the <Formik /> component, but I think we also should update the usage of the <FormikWizard /> and expect a child callback function instead of a render method, so we speak the same language of formik itself.

zaguiini commented 4 years ago

We might support both! The render prop itself is not deprecated. Formik deprecated it in its library

michelts commented 4 years ago

You are right :) The render prop is still supported. I think we might support the child callback function and render prop, but trigger also a deprecation warning recommending to use a child callback also in <FormikWizard />.

zaguiini commented 4 years ago

Sounds good

joshudev commented 4 years ago

Any progress on this?

zaguiini commented 4 years ago

I don't think so