search

zahodi / ansible-mikrotik

Mikrotik module collection for ansible
Apache License 2.0
96 stars 33 forks source link

Moved pythonlibs to module_utils to avoid usage of ENV vars #20

Closed amatamalas closed 6 years ago

amatamalas commented 6 years ago

I have rerun the test with simply using the following command without any ENV var: ansible-playbook tests.yml --diff -i 127.0.0.1,

zahodi commented 6 years ago

@amatamalas looks good. Tests are passing. Can you just remove the "export" line from the ./run_this.sh since we don't need to use that anymore.

senorsmile commented 6 years ago

nice work. this was on our todo list.

amatamalas commented 6 years ago

@zahodi I will add the change and commit it. Thanks for pointing that out!

zahodi commented 6 years ago

lgtm.