zaichaopan / react-aria-components-tailwind-starter

Tailwind react aria components starter kits
https://zaichaopan.github.io/react-aria-components-tailwind-starter
MIT License
29 stars 4 forks source link

Possible addition of an underline offset? #7

Closed gregmsanderson closed 3 months ago

gregmsanderson commented 3 months ago

Hello,

I wonder if you think an offset e.g underline-offset-4 would be nice to add:

export function TextLink(props: LinkProps) {
  return (
    <Link
      {...props}
      className={composeTailwindRenderProps(props.className, 'underline underline-offset-4')}
    />
  );
}

Shadcn and Catalyst both do for their text links since it looks a bit nicer e.g:

offset

I can simply override the class but it seemed a nice addition to the default. I could add a PR if you like.

Thanks.

zaichaopan-alianza commented 3 months ago

@gregmsanderson that looks nicer! Please add it! Thanks!

gregmsanderson commented 3 months ago

Great!

That's done :)

https://github.com/zaichaopan/tailwind-react-aria-components-starter-kits/pull/8