search

zaidakram / expedia

Expedia is a ruby wrapper for EAN (Expedia Affiliate Network)
http://zaidakram.github.io/expedia/
MIT License
48 stars 29 forks source link

Up the colorize dependency version #7

Closed tombruijn closed 10 years ago

tombruijn commented 10 years ago

I ran into an issue with the sshkit gem having the same dependency on colorize. Only it would call options that don't exist yet in version 0.5.8, but do exist in the latest 0.7.x release.

The error: undefined method 'bold' for Color:Module

I updated the colorize gem in the expedia gem, ran the specs on ruby 2.1.2, 2.0.0-p451 and had no failures. Anything else I can do to make sure this gets merged?

zaidakram commented 10 years ago

How about we remove colorize dependency altogether... It was used in a rake task which copies an initializer (In case of rails). Now that I've replaced it with a generator. We should remove this dependency.

tombruijn commented 10 years ago

Great, the less dependencies the better! Then this rake task should be removed: expedia/lib/tasks/expedia.rake, right?

zaidakram commented 10 years ago

Yes it will be removed.

tombruijn commented 10 years ago

Great! Thanks!