search

zaidansani / pe

0 stars 0 forks source link

Error message for invalid IC does not mention that the validation checks for IC validity #2

Open zaidansani opened 1 week ago

zaidansani commented 1 week ago

Bug Description

The error message does not state that the IC needs to be valid (not just checksums, and input, but also that the IC is valid as per SG requirements).

Steps to Reproduce

  1. Add a person with an invalid IC. The one used below is: T1234567D, which is invalid.

Expected Behavior

The error message should include a provision to state that invalid ICs are not allowed.

Screenshots

Pasted image 20241115161513.png

Additional Context

nus-pe-bot commented 1 week ago

Team's Response

We see why it could be misleading to new users.

Items for the Tester to Verify

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: This qualifies as a FeatureFlaw to me because it rejects the input correctly, but the specificity of the error message is wrong. While this is also a functionality bug due to missing information, my bug report focused on that the error was not specifically saying that the NRIC was invalid, but instead talking about the other requirements of the NRIC.

image.png