zaidka / cliget

A Firefox addon to download login-protected files from the command line
https://addons.mozilla.org/en-US/firefox/addon/cliget/
Mozilla Public License 2.0
357 stars 57 forks source link

ssh curl .. #41

Open desaboya opened 7 years ago

desaboya commented 7 years ago

cliget is very cool.

Please add an option to execute the curl command on another machine. With a pre option that would go before the curl or wget command the download could be submitted to a server.

extra cURL pre options: plink -i myprivate.key.ppk user@host

joveian commented 5 years ago

You might be doing one of these already but I suspect you can get it to work without modifying cliget. Since it sounds like plink is a windows thing, I'm not sure how do it in regular windows but at least it could work via bash or such on windows subsystem for linux. If you always want to use it remotely you can alias curl to have the plink prefix. If not, you can make a pcurl alias and type p rather than just . It would also be possible to do options parsing via a shell function; the easiest would just be to require your special option to be the last one and add the plink command if it is present and remove the special option.

My suggestion would be if something like this is added to instead have an option to change the "extra curl options" input into a "curl command" input that includes the binary name and any extra options since that would also cover the "curl binary is named something other than curl" case. I don't know if there is any reason why someone would need an option at the end (other than that as default that makes it easier to see that the command line is updated), but if not this seems less cluttered than an extra text input. I don't know javascript much less firefox extension programming but I think it is likely that this untested diff would change the existing extra options input to be at the beginning and include the binary name (for curl only and not changing the input label text or providing it as an option). I guess you would also need to run the developers edition of firefox to be able to disable the need for extension signing so the shell methods would be easier, but if you really want it to be in cliget and are willing to figure out how to load a modified version then this might work for you.

curl.js.diff.txt