search

zain / jogging

Easier Django logging!
MIT License
103 stars 5 forks source link

Requires middleware to add handlers. #1

Closed ianlewis closed 14 years ago

ianlewis commented 14 years ago

jogging shouldn't require you to add the LoggingMiddleware in order to register the logging handlers. It should only require you to put 'jogging' in INSTALLED_APPS. Adding the logging handlers should happen in init.py or models.py

unbracketed commented 14 years ago

I'd also like to see an alternative approach to having the handlers registered. Logging won't work when unit tests are being run since the middleware never gets invoked.

danaspiegel commented 14 years ago

or in management commands...

ianlewis commented 14 years ago

Management commands wouldn't work. The python logging module needs to be initialized in the running process.

I've implemented the fix for this in my branch but Zain didn't want to import it for some reason.

ianlewis commented 14 years ago

Unbracketed. That's one of the reasons I submitted the bug.

danaspiegel commented 14 years ago

I forked and fixed this as well as a few other items: http://github.com/cathedralpartners/jogging/

Please feel free to pull from our fork.

ianlewis commented 14 years ago

I see what you meant my management commands. Kindly disregard my earlier comment ;p

zain commented 14 years ago

I pulled IanLewis's branch, which fixes this and also includes danaspiegel's fixes. Thanks guys.