search

zaindewsi / guap-wallet

GNU General Public License v3.0
4 stars 2 forks source link

Shared varBalance state #1

Closed zerophin closed 3 years ago

zerophin commented 3 years ago

Major Changes Currently varBalance's state is not shared across different components. I moved varBalance up one component level which allows that state to be passed into other components.

Also, in Coin.jsx I changed the formatting of the price of the coin to reflect the user's preferred currency.

Minor Changes minor change: I also added .idea to .gitignore (it is for the intellJ IDE)

Suggestion I didn't do it here, but I think the variable name varBalance should be changed to something more descriptive like preferredCurrency or prefCurrency.

netlify[bot] commented 3 years ago

:x: Deploy Preview for guap-wallet failed.

:hammer: Explore the source changes: 387c1b51de172fe993128053f984ce5e24237b19

:mag: Inspect the deploy log: https://app.netlify.com/sites/guap-wallet/deploys/60eca0a39147a60008cccee5

JettScythe commented 3 years ago

Hey! We very much appreciate the contribution & the changes look good. We won't be able to accept any changes until July 16th since this is our final project for a web development bootcamp. Thank you! If we don't come back to it, please remind us!

zerophin commented 3 years ago

Hey! We very much appreciate the contribution & the changes look good. We won't be able to accept any changes until July 16th since this is our final project for a web development bootcamp. Thank you! If we don't come back to it, please remind us!

No problem at all! Goodluck on your final