search

zaindewsi / guap-wallet

GNU General Public License v3.0
4 stars 2 forks source link

Update #8

Closed JettScythe closed 2 years ago

JettScythe commented 2 years ago

This PR does quite a few things, but I don't believe the work is completely finished to get this up-to-date. That being said - It should be working better than what is launched & I do recommend merging it. This: 1) Adds Husky and commitizen for meaningful commit messages and pre-commit hooks 2) replaces the coingecko wrapper with bare axios.get requests. This is because the coingecko wrapper was firstly unneeded & secondly caused issues when attempting to upgrade to react 18 with react scripts >= 5 3) updates the used components to use latest react styling 4) switches to yarn. npm is causing me issues left and right nowadays. 5) removes redundant contributors and dependencies sections from the readme 6) replaces storybook with vitebook, same kinda reason as coingecko wrapper removal. 7) updates all dependencies.

netlify[bot] commented 2 years ago

Deploy Preview for guap-wallet failed.

Name Link
Latest commit 0f4d691f7aa8b94157325bd473c52e3d870083a1
Latest deploy log https://app.netlify.com/sites/guap-wallet/deploys/625e2e87b1f9950008f0b004
JettScythe commented 2 years ago

The last fix that I'm aware of is to correct some of the error messages from psf for slp stuff. Will look into it when I get some free time.

JettScythe commented 2 years ago

all good! Wallet it working as expected. We will see some errors in the console if the wallet doesn't have a token balance, but that's no biggie. Not sure how netlify works but I assume the build for production failed? @zaindewsi Looks like node needs to be updated. I believe LTS is 16.14 right now.

zaindewsi commented 2 years ago

Should be able to update the node version through package.json: https://docs.npmjs.com/cli/v7/configuring-npm/package-json#engines

anything after node 14 should work!