Styling & Refactoring - Githubissues

zainfathoni / ojekbelanja

Ojek Belanja

https://ojekbelanja.id

21 stars 8 forks source link

Styling & Refactoring #8

Closed zainfathoni closed 6 years ago

zainfathoni commented 7 years ago

Styling

Minor Styling

~~Center & crop images in Cards vertically & horizontally~~
[x] Fix bug in Cards with different heights

Refactoring

Minor Refactoring

[x] Consider putting ul reset style from FilterCards.css into Base Rules in index.css
[x] Move TokoPicker component under Home page, because it is only used there
~~Use Map instead of plain object for DescriptionList component, refer to ES6 Cheatsheet~~

Major Refactoring

CSS Architecture

Implement https://github.com/jareware/css-architecture

[x] Use consistent class namespacing
Conventions

Implement https://github.com/zainfathoni/ojekbelanja/wiki/Conventions

[x] CSS

[x] CSS Measurement Units

[x] Organizing CSS

[x] SMACSS Methodology

[x] Property Grouping

[x] CSS Commenting

[x] JavaScript

[x] Syntax Preferences

[x] Array & Object Declaration

[x] React

[x] Import Statement

[x] Import Grouping

[x] Import PropTypes

[x] Typechecking