Closed zainsadaqat closed 3 years ago
Hi @zainsadaqat && @aristides1000 ,
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi there,
Awesome job on making the changes requested by the previous reviewer π You've done well implementing some of the requested changes, but there are still some which aren't addressed yet. Let's work on those.
Kindly check the comments under the review.
Happy coding, Cheers!ππ
Feel free to leave any questions or comments in the Issue thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Issue link submitted for the first review, whether it's valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
@mikenath223
Cool. Seems you just assigned it. Kindly request a new review then.
Hello there
Your project is complete! There is nothing else to say π³ Congratulations! π
Happy coding. Cheers! ππ
If you feel something isn't clear enough you can leave a question or comment in the issue thread.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hello!
Here's our project link:
https://github.com/zainsadaqat/javascript-capstone-pokeapi/projects/1