zainsadaqat / portfolio

Hello, my name is Zain Sadaqat and this is my portfolio's repository. Portfolio has been created with HTML, CSS, JavaScript. You can find the live link to my portfolio right below to this description.

https://zainsadaqat.github.io/portfolio/

1 stars 0 forks source link

Develop work and about sections for mobile version of portfolio #2

Closed zainsadaqat closed 3 years ago

zainsadaqat commented 3 years ago

In this pull request, I've done the following tasks:

my previous branch ( hero-section ) needed approval that's why I started working on new sections in a new branch. Please ignore the mistakes in the hero section.

In this branch ( work-about-sections ), I developed a work section and about section by following Figma design template-1.

zainsadaqat commented 3 years ago

Please find the attached screenshots of Portfolio's mobile version below:

Hero Section

Work Section

1) Screenshot from 2021-07-10 17-40-59

2) Screenshot from 2021-07-10 17-41-14

3) Screenshot from 2021-07-10 17-41-27

4) Screenshot from 2021-07-10 17-41-38

About Section

Screenshot from 2021-07-10 17-42-01

Screenshot from 2021-07-10 17-42-27

mimipeshy commented 3 years ago

Hi @zainsadaqat 👋🏾 ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

zainsadaqat commented 2 years ago

Thanks @mimipeshy for approving this pull request and @rloterh for pointing out my mistakes to make me a good developer.