CSS Fixes and Settings route pt2

zairza-cetb / bench-routes-electron

Graphical User Interface for bench-routes service, powered by ReactJS and ElectronJS. This repository is now integrated into bench-routes. You can find bench-routes here: https://github.com/zairza-cetb/bench-routes

7 stars 14 forks source link

CSS Fixes and Settings route pt2 #21

Closed cjharkins closed 5 years ago

cjharkins commented 5 years ago

Hey everyone, sorry about that last mess.

This should pipe in smoothly.

Fixes:

Migrate logic for Notification panel
Fix positioning and emphasize animation for Notification
Add settings route
Simplify click handler for show/hide
Migrate some files to .tsx

cjharkins commented 5 years ago

Harkishen-Singh commented 5 years ago

@cjharkins thanks for showing your interest in the project. Could you please follow the instructions to pass the DCO.?

will review asap. Thanks

ganeshpatro321 commented 5 years ago

@cjharkins looks good, Just few things:

Run npm run lint through the codebase, and check for any errors or warnings and resolve them.
Can you change the icon beside the settings button in the sidebar.

cjharkins commented 5 years ago

@ganeshpatro321 @Harkishen-Singh I'm following the instructions for the DCO, and it isn't giving me the desired result.

I wish all the work I've done was not in vain, however, I don't feel as though I can continue to commit time to fixing this trivial issue.

If you have a fix for me, I will be happy to try it. If not, thank you for the opportunity to contribute! I hope the project goes well :)

ganeshpatro321 commented 5 years ago

Hey @cjharkins . I have updated the minor changes I had asked for and have created an updated PR. Dont worry, your commits are safe ;D Thanks for your contribution, and hope to see more contribution from you. Thanks

ganeshpatro321 commented 5 years ago

Commits merged in PR #24