search

zairza-cetb / bench-routes-electron

Graphical User Interface for bench-routes service, powered by ReactJS and ElectronJS. This repository is now integrated into bench-routes. You can find bench-routes here: https://github.com/zairza-cetb/bench-routes
7 stars 14 forks source link

Convert project to Typescript #7

Closed DavidCabal closed 5 years ago

DavidCabal commented 5 years ago

fixes #6

muskankhedia commented 5 years ago

@DavidCabal Thanks for your interest and contribution in the project. Please convert the javascript code to typescript code while writing the .ts and .tsx files.

DavidCabal commented 5 years ago

@muskankhedia I've updated the App.tsx file to be a typed React component. Create-React-App by default leaves the index.js and serviceWorker.js files as js even when initialized as a Typescript app through their API. There isn't any logic in the App.tsx file yet. Was there something else you were wanting me to update?

ganeshpatro321 commented 5 years ago

Hey @DavidCabal Please resolve the conflicts, so we can review thoroughly.