Fix the repo and loading of powerline

[pablox-cl]

As you might now, the vim-powerline plugin is deprecated in favour of the new omnipotent powerline plugin. Right now it's in beta, but until now it seems to work without issues.

Prolly it could be a good idea, to wait a bit to merge this in the master branch.

[zaiste]

@PaBLoX-CL would you mind updating the README with information about the installation process as well ?

[pablox-cl]

On 21 January 2013 07:21, Zaiste! notifications@github.com wrote:

@PaBLoX-CL https://github.com/PaBLoX-CL would you mind updating the README with information about the installation process as well ?

Sure, I'll do it in the next couple of days.

[pablox-cl]

Actually, maybe a link to the official documentation would be enough. It's quite explanatory, and I don't see the point in duplicating info (exposing to get outdated sometime without noticing it).

What do you think?

[zaiste]

@PaBLoX-CL I merged you changes, but it seems your PR was broken. The second listed commited hasn't been included. Could you check it on your side ?

[pablox-cl]

No, it was. I made a mistake on the first commit, but when I realized it I corrected it.

As you can see on the first commit, i deleted everything and added:

Bundle 'Lokaltok/powerline'

And some weird line, but then I realized that the actual vim-powerline repo, does all the dirty stuff (even checking if the module was installed). In the end (and sorry for that), the only change was delete the lines that configured the fancy symbols within vim.

I still can add a little not on the readme, because now you need to install the python package to run the plugin.

[pablox-cl]

God, I just realized everything is broken. I'm gonna fix it tomorrow. I just realized Lokaltog changed the vim-powerline plugin and even dropped Vundle support (Lokaltog/vim-powerline@c629a71627869334f99afdbbb52c570ac02977c5).

Probably the cleanest way to avoid "warnings" if you don't have the powerline module installed is to create a powerline.vim file in the functions directory that get's loaded if the "fancy" package it's activated. Are you ok with that approach?

[zaiste]

I think it's OK. The bottom line is the users should be always able to easily install vimified.

[AdrienGiboire]

Well, I don't understand. Lokaltog dropped Vundle support but has some built-in support, says the README. Even if I don't know what is he talking about specifically.

About the support of python, you can just add the following:

    if has('python') || has('python3')
        Bundle 'Lokaltog/vim-powerline'
    endif

If you want to echo some informative messages, go ahead.

Why did you remove python from powerline.ext.vim import source_plugin; source_plugin()? That makes Powerline no longer activated at starting. It's not vimified spirit. We do not want users, beginner or not, to have to check the Powerline documentation when starting using vimified.

Since we use Vundle in vimified, and according to the documentation, you have to source source_plugin.vim. You might want to take a look to what I suggest: https://github.com/AdrienGiboire/vimified/commit/42a9bdee168a27fe25dbd5434c8f47ba51e3981e

[pablox-cl]

On 4 February 2013 10:03, Adrien Giboire notifications@github.com wrote:

Well, I don't understand. Lokaltog dropped Vundle support but has some built-in support, says the READMEhttps://github.com/Lokaltog/vim-powerline/commit/c629a71627869334f99afdbbb52c570ac02977c5#L0R9. Even if I don't know what is he talking about specifically.

About the support of python, you can just add the following:

if has('python') || has('python3')
    Bundle 'Lokaltog/vim-powerline'
endif

If you want to echo some informative messages, go ahead.

In Arch Linux there is a package which includes a powerline.vim that do some checking, so maybe I can use that.

Why did you remove python from powerline.ext.vim import source_plugin; source_plugin()https://github.com/PaBLoX-CL/vimified/commit/352417b7116816575ccc241edf4534c51675a638#L0L89? That makes Powerline no longer activated at starting. It's not vimified spirit. We do not want users, beginner or not, to have to check the Powerline documentation when starting using vimified.

I did it, because a couple of days ago the Lokaltog/vim-poweline repo had some basic checking and loading of the plugin (in fact, contained that line). Now he dropped Vundle support, after running :BundleUpdate I found that the .vimrc is broken.

Since we use Vundle in vimified, and according to the documentationhttp://lokaltog.github.com/powerline/overview.html#installation, you have to source source_plugin.vim. You might want to take a look to what I suggest: AdrienGiboire@42a9bdehttps://github.com/AdrienGiboire/vimified/commit/42a9bdee168a27fe25dbd5434c8f47ba51e3981e

I'm in shift right now, I'll check it asap

[AdrienGiboire]

I took a look at the source of the Archlinux package which you talked about. It does nothing concerning the Vim support for python. If the user did not compiled Vim enabling python support, the package will do its work but the plugin will still not work.

I feel like I am missing something. Am I right?

[pablox-cl]

No, it doesn't. But it does have some sane checking. In my case for instance, since I've got the python module installed (and the package also has a powerline.vim file on the vimfiles/plugin directory), the plugin gets loaded without ANY action on my own (since arch linux vim comes with python2 support by default).

Sadly, that won't be necessary the rule so we have to manage someway. My guess is to add some "code check" in the fancy package part, and then the load of the powerline.vim. In Arch Linux machines the script will appear twice, but it won't run the second because it starts with:

if exists('g:powerline_loaded')
    finish
endif
let g:powerline_loaded = 1
...

---

I pushed a commit into the branch that was merged... maybe you can re-open the issue so I can make the pull request again or maybe you can merge them.