search

zaiste / vimified

Yet another Vim configuration
http://zaiste.github.com/vimified/
684 stars 131 forks source link

Check to see if zsh is even used #87

Closed xiaogwu closed 10 years ago

xiaogwu commented 10 years ago

Last commit (9569441) was breaking my vim. Whenever I try to start vim it just would segfault.

$ vim [1]+ Stopped vim

If I take out this change by removing the "\ -i" vim starts up fine.

I don't use zsh so not sure if that has anything to do with it. My pull request checks to see if the user is even using zsh by checking the presence of a .zshrc file.

AdrienGiboire commented 10 years ago

I'm not okay with this because you might not use .zshrc file to configure ZSH. .zshenv and .zprofile both work as well.

The problem comes from the use of executable(). It was misused as the arg is a path when it should be just the name of the program. If you have have ZSH installed and in your $PATH, then executable() will find it.

I improved it here: https://github.com/AdrienGiboire/vimified/commit/b9c4380770c15608cb73948db4db79158a18bffa

Let me know if it helps. Else, there is a real thing going wrong and I stick to the point that checking on any config file is not the right way to deal with it :)