zajac-grzegorz / homeassistant-addon-cups-airprint

CUPS addon with working Avahi in reflector mode
15 stars 22 forks source link

CUPS user `print` has no password set as `mkpasswd` is missing #6

Closed MaxWinterstein closed 7 months ago

MaxWinterstein commented 7 months ago
docker build -t foo .
...
 docker run --rm -ti --entrypoint /bin/bash foo
root@8ba099d1a4b8:/# mkpasswd
bash: mkpasswd: command not found
root@8ba099d1a4b8:/# cat /etc/passwd | grep print
print:x:1000:1000::/home/print:/bin/bash
root@8ba099d1a4b8:/# apt update
...
root@8ba099d1a4b8:/# apt install whois
...
root@8ba099d1a4b8:/# mkpasswd
Password:
$y$j9T$qkGeygtaoLpHoNN6vN0CU0$eEab58FX7R8QimvHKzoQeOBvYJkOUpE6/voQqAk9w66
root@8ba099d1a4b8:/# which mkpasswd
/usr/bin/mkpasswd

Sadly command not found is not raised through the subshell / argument and docker does not abort.

Proposal to fix: #5

zajac-grzegorz commented 7 months ago

thanks!

MaxWinterstein commented 7 months ago

Thanks for your work 👍

Fixed via #5 /close