search

zak-hassan / WhoTeachsWhat

JBoss JSP Application for Data Management
0 stars 0 forks source link

FacultyToCourseInSemesterYear not adding correctly #149

Closed ghost closed 10 years ago

ghost commented 10 years ago

Based on the database design and the controller, it looks at though the controller does not take in or add..

eval_1, eval_2, eval_3, eval_1_ans, eval_2_ans, eval_3_ans, factor_id

Something to note: These three fields are not needed. eval_1_ans, eval_2_ans, eval_3_ans

I can confirm that the AJAX to add is working since I got a response back, but upon viewing the page I get a 500 internal server error. Looking at the database I see that

eval_1, eval_2, eval_3, eval_1_ans, eval_2_ans, eval_3_ans, factor_id

are all set to zero. Since eval_1, eval_2, eval_3, factor_id are foreign keys, I can somewhat understand the error.

Error log here. https://www.dropbox.com/s/pedlw5svinrk49s/WTW_console_error_April_6_2014_500_Interal_Server_Error.txt

One last thing. Commenting out the data table causes the page the load correctly. It is only when access the data that this error occurs. Similarly, remove the row in the database causes the page to work just fine, even with the data table uncommented.

zak-hassan commented 10 years ago

Its actually missing this fields: getSemesterId

Exception was thrown because this method was used and there was no data to display.. I will fix this

ghost commented 10 years ago

Okay. While you are fixing it, make sure to remove eval_1_ans, eval_2_ans, eval_3_ans along with the foreign key relationship.

zak-hassan commented 10 years ago

Well I won't be committing these changes until I'm done with spring security.

On Sun, Apr 6, 2014 at 10:36 PM, Anil Santokhi notifications@github.comwrote:

Okay. While you are fixing it, make sure to remove eval_1_ans, eval_2_ans, eval_3_ans along with the foreign key relationship.

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/149#issuecomment-39691917 .

ghost commented 10 years ago

No problem. The validation for that page is done (but untested) and the AJAX was working before. It shouldn't be hard for me to acclimate it to your changes.

Will your next push include changes to Factor? The controller is a copy of Faculty, as is the service layer. I don't see a Dao either. Anyways, Factor is in the same situation as FacultyToCourseInSemesterYear. It has validation and AJAX but hasn't been properly tested.

Right now I am working on the swift.

ghost commented 10 years ago

This was an error on in the foreach loop. I was calling a method that didn't exist anymore (get_semesterId()).

This issue is resolved.