search

zak-hassan / WhoTeachsWhat

JBoss JSP Application for Data Management
0 stars 0 forks source link

Changes to model, service layer, controller and Dao #158

Closed ghost closed 10 years ago

ghost commented 10 years ago

We still need to fix a few models..

Course needs eval_1, eval_2, eval_3

EvalFactor needs to drop factor_val

CourseInSemester needs to drop eval_1, eval_2, eval_3, eval_1_ans, eval_2_ans, eval_3_ans, addition_attribute

FacultyToCourseInSemesterYear needs eval_1, eval_2, eval_3 and factor_id.

FacultyToCourseInSemesterYear needs to drop compHour_allowance

We need to set a faculty member's compHour allowance somewhere. It can't be per FacultyCourseInSemesterYear

Without these changes, I can't completed fix the UI. Validation is done, the AJAX requests need to be updated to reflect these changes. When will this be done? This is critical.

zak-hassan commented 10 years ago

I'm working on this fix but remember any model changes will have a ripple effect but I can do it. Firstly where are you storing the values for EvalFactor? I think this is wrong...

ghost commented 10 years ago

It's not wrong. Courses have their own evaluation factors. It's with course. It's also with FacultyToCourseInSemester because the default course evaluations can be overridden in rare cases.

Evaluation table just holds the name of the evaluation. That's it. It can't hold eval factor because every course has its own.

zak-hassan commented 10 years ago

Did you change the model file to reflect this change. Remember if we keep making changes and something goes wrong, atleast we have the model file to regenerate the database.

ghost commented 10 years ago

I didn't. There are many issues about this.

zak-hassan commented 10 years ago

Well, really the change to the modal file will only take like 10 mins. We can not make any more updates to SQL or through code for the database code. It will be hard to maintain and if we make mistakes then no one will be able to fix any issues. Iets end this project off with a good starting point for the student who will maintain this. Can you update this Model file and I will generate the models and update all the service methods and controllers.

https://github.com/zmhassan/WhoTeachsWhat/blob/master/DBDesign/MysqlDBModal.mwb

zak-hassan commented 10 years ago

Sooner or later the model file will have to be updated. Its hard to maintain like this.

ghost commented 10 years ago

It's pretty behind. Give me a bit to update this.

ghost commented 10 years ago

I updated the MySQL file. One thing I didn't do. FacultyToCourseInSemesterYear has a factor_id but it's not a foreign key to the factor table. It should be.

Please don't confuse evaluation and factor.

zak-hassan commented 10 years ago

Database has been updated and application is functional. Pushed code in and I say its safe to close this issue

zak-hassan commented 10 years ago

Well if this changes in the model then I have generated it and if not then you will have to update the model and push it in.

On Tue, Apr 8, 2014 at 12:19 AM, Anil Santokhi notifications@github.comwrote:

I updated the MySQL file. One thing I didn't do. FacultyToCourseInSemesterYear has a factor_id but it's not a foreign key to the factor table. It should be.

Please don't confuse evaluation and factor.

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39810389 .

ghost commented 10 years ago

There are errors in service methods and controllers. STS has highlighted them in red. Please fix this and check your work before committing.

ghost commented 10 years ago

Let me know as soon as this is done. Three pages are not working as a result of controller/service layer errors.

ghost commented 10 years ago

Zak, if this is not done soon, I won't have enough time to fix these before our final presentation. We may fail the project.

zak-hassan commented 10 years ago

This is fixed. And code is pushed in and I will update the vm to reflect this

ghost commented 10 years ago

The UI has to be updated to make the proper Ajax requests. Forms have to change too. I don't think those pages will work.

This is fixed. And code is pushed in and I will update the vm to reflect this

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39858084 .

zak-hassan commented 10 years ago

As long as the form fields are using the correct fields then it should work fine.

ghost commented 10 years ago

EvalFactor works. Course, CourseInSemester and FacultyToCourseInSemesterYear needs an update for the new model.

As long as the form fields are using the correct fields then it should work fine.

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39859712 .

ghost commented 10 years ago

They are not making the proper AJAX requests, I think. It was late. I have not slept. I cannot remember.

EvalFactor works. Course, CourseInSemester and FacultyToCourseInSemesterYear needs an update for the new model.

  • Anil D Santokhi On Apr 8, 2014 11:09 AM, "Zak Hassan" notifications@github.com wrote:

As long as the form fields are using the correct fields then it should work fine.

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39859712 .

ghost commented 10 years ago

I checked the github code.

Every form is perfect. The AJAX is not however. If we avoid posting those pages, we should make it through. Just to clarify, the AJAX works with the OLD controller code for those pages. Despite the new forms, I am careful to only post old data. Basically I did everything I could.

On Tue, Apr 8, 2014 at 11:20 AM, Anil Santokhi anil.d.santokhi@gmail.comwrote:

They are not making the proper AJAX requests, I think. It was late. I have not slept. I cannot remember.

  • Anil D Santokhi On Apr 8, 2014 11:19 AM, "Anil Santokhi" anil.d.santokhi@gmail.com wrote:

EvalFactor works. Course, CourseInSemester and FacultyToCourseInSemesterYear needs an update for the new model.

  • Anil D Santokhi On Apr 8, 2014 11:09 AM, "Zak Hassan" notifications@github.com wrote:

As long as the form fields are using the correct fields then it should work fine.

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39859712 .

ghost commented 10 years ago

Zak, the controllers and service methods are not updated for Course, CourseInSemester or FacultyToCourseInSemesterYear.

These pages are critical to our application. When is this going to be fixed?

zak-hassan commented 10 years ago

I am working on this now so it should be done soon.

ghost commented 10 years ago

Okay, cool. Let me know when the code is pushed and I'll update the AJAX on those pages.

zak-hassan commented 10 years ago

You can test Course. As for CourseInSemester it should work. We are missing the insert script so when ever you can lets try and generate that. I'd like to try it out on the VM.

On Wed, Apr 9, 2014 at 12:02 AM, Anil Santokhi notifications@github.comwrote:

Okay, cool. Let me know when the code is pushed and I'll update the AJAX on those pages.

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39926749 .

ghost commented 10 years ago

Well before that, we should really make sure we actually add a course through a UI page.

zak-hassan commented 10 years ago

It was a UI problem. I will fix it however. Just for a note to clarify the there was a field used that didn't map back to the model.

ghost commented 10 years ago

Factor has stopped working too. I can literally erase the entire content of the JSP page and it will not work. When I comment out the service call in the request mapping in the controller, it works.

If throws an exception. I can verify this..

@RequestMapping(value = "/viewFactor", method = RequestMethod.GET) public String view(ModelMap model) { try { model.addAttribute("allFactors", factorService.getAll()); } catch (Exception ex) { return "Faculty/viewFaculty"; }

    return "Factor/viewFactor";
}

It will go into viewFaculty

Course has this same problem. I imagine the other pages do as well.

zak-hassan commented 10 years ago

Factor is now working.

On Wed, Apr 9, 2014 at 12:28 AM, Anil Santokhi notifications@github.comwrote:

Factor has stopped working too. I can literally erase the entire content of the JSP page and it will not work. When I comment out the service call in the request mapping in the controller, it works.

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39927716 .

ghost commented 10 years ago

Are the changes pushed in? It's still not working for me and still throws an exception.

zak-hassan commented 10 years ago

Yea their pushed in. Do a clean build and see what happens.

On Wed, Apr 9, 2014 at 12:45 AM, Anil Santokhi notifications@github.comwrote:

Are the changes pushed in? It's still not working for me and still throws an exception.

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39928247 .

ghost commented 10 years ago

Same thing. It throws an exception and Faculty loads.

zak-hassan commented 10 years ago

Can you send the console log. Let me see the exception..

On 4/9/14, Anil Santokhi notifications@github.com wrote:

Same thing. It throws an exception and Faculty loads.

Reply to this email directly or view it on GitHub: https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39928511

ghost commented 10 years ago

I sent an email with it.

zak-hassan commented 10 years ago

Got it and fixed it.

On Wed, Apr 9, 2014 at 12:57 AM, Anil Santokhi notifications@github.comwrote:

I sent an email with it.

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39928695 .

ghost commented 10 years ago

I did a git pull and it's still not working. Are you testing your changes before making them?

zak-hassan commented 10 years ago

Well I tested Factor UI locally and it works for me.

On Wed, Apr 9, 2014 at 1:29 AM, Anil Santokhi notifications@github.comwrote:

I did a git pull and it's still not working. Are you testing your changes before making them?

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39929937 .

ghost commented 10 years ago

Odd. It doesn't work for me, even if I comment out the data table. Only when the call to the service method is commented out does it work.

On Wed, Apr 9, 2014 at 1:34 AM, Zak Hassan notifications@github.com wrote:

Well I tested Factor UI locally and it works for me.

On Wed, Apr 9, 2014 at 1:29 AM, Anil Santokhi <notifications@github.com

wrote:

I did a git pull and it's still not working. Are you testing your changes before making them?

Reply to this email directly or view it on GitHub< https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39929937

.

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930114 .

zak-hassan commented 10 years ago

Are you sure you pull down the latest code changes?

On Wed, Apr 9, 2014 at 1:36 AM, Anil Santokhi notifications@github.comwrote:

Odd. It doesn't work for me, even if I comment out the data table. Only when the call to the service method is commented out does it work.

On Wed, Apr 9, 2014 at 1:34 AM, Zak Hassan notifications@github.com wrote:

Well I tested Factor UI locally and it works for me.

On Wed, Apr 9, 2014 at 1:29 AM, Anil Santokhi <notifications@github.com

wrote:

I did a git pull and it's still not working. Are you testing your changes before making them?

Reply to this email directly or view it on GitHub<

https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39929937

.

Reply to this email directly or view it on GitHub< https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930114

.

  • Anil D. Santokhi

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930186 .

ghost commented 10 years ago

Git says it's already up-to-date

On Wed, Apr 9, 2014 at 1:37 AM, Zak Hassan notifications@github.com wrote:

Are you sure you pull down the latest code changes?

On Wed, Apr 9, 2014 at 1:36 AM, Anil Santokhi <notifications@github.com

wrote:

Odd. It doesn't work for me, even if I comment out the data table. Only when the call to the service method is commented out does it work.

On Wed, Apr 9, 2014 at 1:34 AM, Zak Hassan notifications@github.com wrote:

Well I tested Factor UI locally and it works for me.

On Wed, Apr 9, 2014 at 1:29 AM, Anil Santokhi < notifications@github.com

wrote:

I did a git pull and it's still not working. Are you testing your changes before making them?

Reply to this email directly or view it on GitHub<

https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39929937

.

Reply to this email directly or view it on GitHub<

https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930114

.

  • Anil D. Santokhi

Reply to this email directly or view it on GitHub< https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930186

.

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930259 .

zak-hassan commented 10 years ago

Go into the add method in the facultyService.add and update this method:

setFactorValue

On Wed, Apr 9, 2014 at 1:37 AM, Zakeria Hassan zak.hassan1010@gmail.comwrote:

Are you sure you pull down the latest code changes?

On Wed, Apr 9, 2014 at 1:36 AM, Anil Santokhi notifications@github.comwrote:

Odd. It doesn't work for me, even if I comment out the data table. Only when the call to the service method is commented out does it work.

On Wed, Apr 9, 2014 at 1:34 AM, Zak Hassan notifications@github.com wrote:

Well I tested Factor UI locally and it works for me.

On Wed, Apr 9, 2014 at 1:29 AM, Anil Santokhi <notifications@github.com

wrote:

I did a git pull and it's still not working. Are you testing your changes before making them?

Reply to this email directly or view it on GitHub<

https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39929937

.

Reply to this email directly or view it on GitHub< https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930114

.

  • Anil D. Santokhi

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930186 .

ghost commented 10 years ago

Update it to what?

On Wed, Apr 9, 2014 at 1:38 AM, Zak Hassan notifications@github.com wrote:

Go into the add method in the facultyService.add and update this method:

setFactorValue

On Wed, Apr 9, 2014 at 1:37 AM, Zakeria Hassan <zak.hassan1010@gmail.com

wrote:

Are you sure you pull down the latest code changes?

On Wed, Apr 9, 2014 at 1:36 AM, Anil Santokhi <notifications@github.com wrote:

Odd. It doesn't work for me, even if I comment out the data table. Only when the call to the service method is commented out does it work.

On Wed, Apr 9, 2014 at 1:34 AM, Zak Hassan notifications@github.com wrote:

Well I tested Factor UI locally and it works for me.

On Wed, Apr 9, 2014 at 1:29 AM, Anil Santokhi < notifications@github.com

wrote:

I did a git pull and it's still not working. Are you testing your changes before making them?

Reply to this email directly or view it on GitHub<

https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39929937

.

Reply to this email directly or view it on GitHub<

https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930114

.

  • Anil D. Santokhi

Reply to this email directly or view it on GitHub< https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930186

.

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930288 .

zak-hassan commented 10 years ago

Can you look at this page and confirm this is the same in your code:

https://github.com/zmhassan/WhoTeachsWhat/commit/87d90ef22ed465bb8fc93101b9f2de0aa0a03268

On Wed, Apr 9, 2014 at 1:38 AM, Anil Santokhi notifications@github.comwrote:

Git says it's already up-to-date

On Wed, Apr 9, 2014 at 1:37 AM, Zak Hassan notifications@github.com wrote:

Are you sure you pull down the latest code changes?

On Wed, Apr 9, 2014 at 1:36 AM, Anil Santokhi <notifications@github.com

wrote:

Odd. It doesn't work for me, even if I comment out the data table. Only when the call to the service method is commented out does it work.

On Wed, Apr 9, 2014 at 1:34 AM, Zak Hassan notifications@github.com wrote:

Well I tested Factor UI locally and it works for me.

On Wed, Apr 9, 2014 at 1:29 AM, Anil Santokhi < notifications@github.com

wrote:

I did a git pull and it's still not working. Are you testing your changes before making them?

Reply to this email directly or view it on GitHub<

https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39929937

.

Reply to this email directly or view it on GitHub<

https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930114

.

  • Anil D. Santokhi

Reply to this email directly or view it on GitHub<

https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930186

.

Reply to this email directly or view it on GitHub< https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930259

.

  • Anil D. Santokhi

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930281 .

ghost commented 10 years ago

It is the same.

On Wed, Apr 9, 2014 at 1:40 AM, Zak Hassan notifications@github.com wrote:

Can you look at this page and confirm this is the same in your code:

https://github.com/zmhassan/WhoTeachsWhat/commit/87d90ef22ed465bb8fc93101b9f2de0aa0a03268

On Wed, Apr 9, 2014 at 1:38 AM, Anil Santokhi <notifications@github.com

wrote:

Git says it's already up-to-date

On Wed, Apr 9, 2014 at 1:37 AM, Zak Hassan notifications@github.com

wrote:

Are you sure you pull down the latest code changes?

On Wed, Apr 9, 2014 at 1:36 AM, Anil Santokhi < notifications@github.com

wrote:

Odd. It doesn't work for me, even if I comment out the data table. Only when the call to the service method is commented out does it work.

On Wed, Apr 9, 2014 at 1:34 AM, Zak Hassan <notifications@github.com

wrote:

Well I tested Factor UI locally and it works for me.

On Wed, Apr 9, 2014 at 1:29 AM, Anil Santokhi < notifications@github.com

wrote:

I did a git pull and it's still not working. Are you testing your changes before making them?

Reply to this email directly or view it on GitHub<

https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39929937

.

Reply to this email directly or view it on GitHub<

https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930114

.

  • Anil D. Santokhi

Reply to this email directly or view it on GitHub<

https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930186

.

Reply to this email directly or view it on GitHub<

https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930259

.

  • Anil D. Santokhi

Reply to this email directly or view it on GitHub< https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930281

.

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930370 .

zak-hassan commented 10 years ago

Take a look at what I see. Its working.. screenshot 2014-04-09 01 41 40

ghost commented 10 years ago

I am seeing this.

On Wed, Apr 9, 2014 at 1:43 AM, Zak Hassan notifications@github.com wrote:

Take a look at what I see. Its working.. [image: screenshot 2014-04-09 01 41 40]https://cloud.githubusercontent.com/assets/1269759/2652354/dc1f18b6-bfa9-11e3-9425-d12743d0eeab.png

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930496 .

ghost commented 10 years ago

Odd. No idea why google didn't show the image. One moment.

On Wed, Apr 9, 2014 at 1:46 AM, Anil Santokhi anil.d.santokhi@gmail.comwrote:

I am seeing this.

On Wed, Apr 9, 2014 at 1:43 AM, Zak Hassan notifications@github.comwrote:

Take a look at what I see. Its working.. [image: screenshot 2014-04-09 01 41 40]https://cloud.githubusercontent.com/assets/1269759/2652354/dc1f18b6-bfa9-11e3-9425-d12743d0eeab.png

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39930496 .

  • Anil D. Santokhi

ghost commented 10 years ago

Okay, so any idea on when Course, FacultyToCourseInSemesterYear and CourseInSemester will have their service methods and controllers updated to reflect the new model?

zak-hassan commented 10 years ago

Course is working.

On Wed, Apr 9, 2014 at 1:57 AM, Anil Santokhi notifications@github.comwrote:

Okay, so any idea on when Course, FacultyToCourseInSemesterYear and CourseInSemester will have their service methods and controllers updated to reflect the new model?

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39931011 .

zak-hassan commented 10 years ago

The rest I'm going to fix in the next 10 mins or so.

On Wed, Apr 9, 2014 at 1:59 AM, Zakeria Hassan zak.hassan1010@gmail.comwrote:

Course is working.

On Wed, Apr 9, 2014 at 1:57 AM, Anil Santokhi notifications@github.comwrote:

Okay, so any idea on when Course, FacultyToCourseInSemesterYear and CourseInSemester will have their service methods and controllers updated to reflect the new model?

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39931011 .

ghost commented 10 years ago

No it's not. The controller and service methods are incorrect.

On Wed, Apr 9, 2014 at 1:59 AM, Zak Hassan notifications@github.com wrote:

Course is working.

On Wed, Apr 9, 2014 at 1:57 AM, Anil Santokhi <notifications@github.com

wrote:

Okay, so any idea on when Course, FacultyToCourseInSemesterYear and CourseInSemester will have their service methods and controllers updated to reflect the new model?

Reply to this email directly or view it on GitHub< https://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39931011

.

Reply to this email directly or view it on GitHubhttps://github.com/zmhassan/WhoTeachsWhat/issues/158#issuecomment-39931115 .

ghost commented 10 years ago

Unless you haven't pushed a change, the course controller and service aren't passing the evaluation factors. It's using the old design.