zakalawe / 737-800

Boeing 737-800 for Flightgear, with various fixes from Josh Davidson and James. Will be merged back into FGaddon peridoically
GNU General Public License v2.0
5 stars 2 forks source link

Improve 3D model of ISFD, add assumed temperature #14

Closed legoboyvdlp closed 5 years ago

legoboyvdlp commented 5 years ago

Hi, This fixes the baro knob ISFD and makes it smoother, fixes the texture of the N1 limit knob (in preparation to make it work in the future), and makes the MFD buttons mesh instead of just a flat texture.

image

image

I also added assumed temperature display on the EICAS: image

However, I have a very strange error:

Nasal runtime error: No such member: setText 430.33 [ALRT]:nasal at C:/Users/redpa/Documents/FlightGear/Custom Aircraft/737-800/Models/Instruments/EICAS/upperEICAS.nas, line 89 430.33 [ALRT]:nasal called from: C:/Users/redpa/Documents/FlightGear/Custom Aircraft/737-800/Models/Instruments/EICAS/upperEICAS.nas, line 45

I've no idea what is causing this -- "assumeTemp" is in the SVG keys and is in the .svg file.

Have you ever seen this one before?

zakalawe commented 5 years ago

Awesome, thanks!

legoboyvdlp commented 5 years ago

@zakalawe the changes possibly broke master - there is a breaking nasal error. Sorry, I should have been clear that I was looking for feedback as how to resolve the nasal error before merging.

Specific nasal error: Nasal runtime error: No such member: setText 430.33 [ALRT]:nasal at C:/Users/redpa/Documents/FlightGear/Custom Aircraft/737-800/Models/Instruments/EICAS/upperEICAS.nas, line 89 430.33 [ALRT]:nasal called from: C:/Users/redpa/Documents/FlightGear/Custom Aircraft/737-800/Models/Instruments/EICAS/upperEICAS.nas, line 45

I did add it to the SVG keys and it exists in the .svg file...

zakalawe commented 5 years ago

Oh sorry, my bad for not checking. I will take a look at the error!

zakalawe commented 5 years ago

I'm not seeing the assumed temp, but also not seeing the error - do I need to do something to trigger it?

legoboyvdlp commented 5 years ago

Not too sure - I'll check again. Assumed temperature should be visible when instrumentation/fmc/inputs/assumed-temp-deg-c has a value?

zakalawe commented 5 years ago

Okay, for some reason the assumeTemp element gets turned into a group, with children. Is there anything special about it? Something is confusing the Nasal / Canvas SVG parser but I can't see why it's different.

zakalawe commented 5 years ago

Okay, for some reason the assumeTemp element gets turned into a group, with children. Is there anything special about it? Something is confusing the Nasal / Canvas SVG parser but I can't see why it's different.

Right, it's the multiple/nested tspan children which throw it off, removing them and everything works as expected.

legoboyvdlp commented 5 years ago

It shouldn't 😕

Thanks for fixing - feel free to push it, as I'm not honestly sure what exactly you mean by tspan children.

zakalawe commented 5 years ago

Fix is pushed now!

legoboyvdlp commented 5 years ago

Many thanks!