Refactoring. Breaking change!

[nrot]

What done:

• Cargo clippy fix. Checked and not accepted if is bad
• Background pattern move to own mod. This need for better expanding and split by parts. But this breaking change. In this point i have some questions

Questions about background pattern api:

• Why SnarlStyle::new is constant but not the SnarlStyle::default ? Default::default pattern used in many crates. new or "builder" use depended on complexity of structure. ""Public fields" pattern is also used if all fields types is public. What pattern you want to used ?
• SnarlStyle bg_pattern: Option<BackgroundPattern> this field can be Option<Box<dyn BackgroundPatternTrait> or just

  pub enum BackgroundPattern{
  #[default]
  None,
  Grid(Grid),
  ... Another patterns
  }

  and don`t needed to use Option. Which way will you choose?

[zakarumych]

I'll review it later, but to answer your questions:

SnarlStyle::default method can't be const because const trait impls are not stable yet.

Background style is in Option because None means not "no pattern", it means "unspecified". Trait object for pattern belongs to enum variant Other

[nrot]

I mean SnarStyle::new don't have any argument, why just not use Trait Default::default without const ? For what you need use const for new ? Background::None also mean "no pattern" ?

I'am discussion with you. If you say - i just step back and take for other things

[zakarumych]

Having fn new() with no arguments is pretty common. And implementing Default::default via call to it to ensure they are consistent. After that adding const to pure functions is just a habit of mine. This way you won't have a problem if you suddenly need use it in constant context. But I don't add const to functions that may become non-pure in future without signature change, since removing const would be a breaking change.

[nrot]

Ok, i will implementing Default::default. What about BackgroundPattern::None ? This more simple than use Option<BackgroundPattern>

[zakarumych]

SnarlStyle already implements Default. BackgroundPattern::None means "no pattern", bg_pattern: None means unspecified, and there' can be some default pattern. For no-pattern you may add BackgroundPattern::NoPattern

[nrot]

Please review when you can

[zakarumych]

This looks good to me!

Thank you, I will merge it. I have some other changes to push before release though.