search

zakarybk / crosshair_designer

https://steamcommunity.com/sharedfiles/filedetails/?id=590788321
1 stars 0 forks source link

Screen resolution check only triggered when menu is open #5

Closed zakarybk closed 4 years ago

zakarybk commented 4 years ago

https://github.com/zakarybk/crosshair_designer/blob/930d053ca6ee5f81cc23eb8a386e966012c70d19/lua/crosshair-designer/menu.lua#L44-L51

This could be a problem in the future if other parts of the Crosshair Designer rely on _CrosshairDesignerDetectedResolutionChange from being run. It just needs to be moved outside of the if statement checking if the menu is open, otherwise this would be unexpected behaviour.

zakarybk commented 4 years ago

Resolved in commit: 817f25e26aa595b70974caef28ce33068d1d7298