zakird / wkhtmltopdf_binary_gem

Ruby gem containing easily installable access to wkhtmltopdf application
https://rubygems.org/gems/wkhtmltopdf-binary
Apache License 2.0
184 stars 346 forks source link

Add back support for Amazon Linux 1 #101

Closed entretechno-jeremiah closed 3 years ago

entretechno-jeremiah commented 4 years ago

The VERSION_ID for Amazon Linux 1 can start (always starts?) with a year beginning with "2". This change looks for a word boundary after the "2" to determine whether it's Amazon Linux 1 or 2.

pedrofurtado commented 3 years ago

@unixmonkey I think we can close this PR without merge, because Amazon Linux 1/2 is already recognized in source code:

https://github.com/zakird/wkhtmltopdf_binary_gem/blob/master/bin/wkhtmltopdf#L26-L30

🍻