search

zakird / wkhtmltopdf_binary_gem

Ruby gem containing easily installable access to wkhtmltopdf application
https://rubygems.org/gems/wkhtmltopdf-binary
Apache License 2.0
184 stars 346 forks source link

Add support for Rocky 8 #126

Closed motomasini closed 2 years ago

motomasini commented 2 years ago

With the EOL of Centos reached some of us will migrate to Rocky Linux. So it would be good to support Rocky linux 8. We can use the same binary as Centos 8 for that

pedrofurtado commented 2 years ago

Thank you for your contribution, @motomasini ! 🤝

@unixmonkey I think we are ready to merge

motomasini commented 2 years ago

@pedrofurtado Np ;).

It seems that the build on Centos fail due to the EOL of Centos, we could update the mirror list to the new stream repo

https://centos.org/centos-stream/#centos-stream-8

we could also add a test to rocky linux as maybe I should have done with my PR

motomasini commented 2 years ago

follow up on #127